Add ELIP for AMP2 descriptors - #43
Open
LeoComandini wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
LWK MR with candidate reference impl used to generate test vectors: Blockstream/lwk#173 |
delta1
approved these changes
Jul 31, 2026
Member
There was a problem hiding this comment.
This looks great to me @LeoComandini.
Let's assign ELIP-153 then I'm happy to ACK. Left some very minor comments.
Verified the test vectors.
|
|
||
| ====User Xpub==== | ||
|
|
||
| <code>USER_XPUB</code> is derived from the user master key using <code>USER_PATH</code>, a [https://github.com/bitcoin/bips/blob/master/bip-0044.mediawiki BIP44] BIP44 derivation path: |
Member
There was a problem hiding this comment.
nit: duplicate "BIP44"
Suggested change
| <code>USER_XPUB</code> is derived from the user master key using <code>USER_PATH</code>, a [https://github.com/bitcoin/bips/blob/master/bip-0044.mediawiki BIP44] BIP44 derivation path: | |
| <code>USER_XPUB</code> is derived from the user master key using <code>USER_PATH</code>, a [https://github.com/bitcoin/bips/blob/master/bip-0044.mediawiki BIP44] derivation path: |
| ====Descriptor Blinding Key==== | ||
|
|
||
| The descriptor blinding key <code>VIEW</code> is a '''view key''' as specified in [https://github.com/ElementsProject/ELIPs/blob/main/elip-0150.mediawiki ELIP-150], derived as follows: | ||
| * Get the server xpub fingerprint, <code>server_fingerprint</code> |
Member
There was a problem hiding this comment.
A careless reader (like my clanker) might use the fingerprint of SERVER_XPUB here instead of the fingerprint of original, un-derived AMP2 server master xpub.
Maybe a small clarification here, or otherwise add another specifier like SERVER_MASTER_XPUB to differentiate?
Suggested change
| * Get the server xpub fingerprint, <code>server_fingerprint</code> | |
| * Get the fingerprint of the original AMP2 server's master xpub ('''not''' the fingerprint of <code>SERVER_XPUB</code>), <code>server_fingerprint</code> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.